Rework of checksum dialogs.
ClosedPublic

Authored by abika on Mar 9 2017, 6:41 PM.

Details

Summary

See commit messages:


Dialogs: access encapsulation of checksum dialogs

Dialogs: code style improvements for checksum dialog

Dialogs: removed support for cfv in checksum dialog
Because cfv is an old tool, is not under active development and does not offer
much advantages over the common tools md5sum, sha1sum, etc. which should be present
on every system.
Additionally this allows much simpler code and will help fixing a security
related bug when verifying checksums.

Dialogs: double fix for running create checksum dialog without input files
Create progress is displayed forever waiting for checksum tools invoked without files.

Dialogs: fix filename dialog when saving created checksum file
KUrlRequester is for opening files, not saving.
FIXED: [ 335993 ] save checksum does not work as expected
BUG: 335993

Dialogs: rework of entire checksum dialog classes

  • Dialogs now QWizards.
  • Removed support for *deep tools. Standard tools can create/verify checksums in directories now.
  • Verify dialog should now be invoked with checksum file, not the files to check. Required for...
  • ...important bug fix: standard tools did not verify selected files, but only files in checksum file.

CCBUG: 363398

Test Plan

Done a lot of hashing and verifying.

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika created this revision.Mar 9 2017, 6:41 PM
martinkostolny accepted this revision.Mar 10 2017, 12:27 AM
martinkostolny added a subscriber: martinkostolny.

Very nice! Thanks Alex! :)

I've noticed a few typos in comments, see code comments below.

krusader/Dialogs/checksumdlg.h
36–37

Base class

42

specified

This revision is now accepted and ready to land.Mar 10 2017, 12:27 AM
Closed by commit R167:fd7e4e91b814: Dialogs: access encapsulation of checksum dialogs (authored by Alexander Bikadorov <alex.bikadorov@kdemail.net>). · Explain WhyMar 14 2017, 8:30 PM
This revision was automatically updated to reflect the committed changes.
abika marked 2 inline comments as done.Mar 14 2017, 8:33 PM

Thanks! Typos fixed