| cmollekopf |
| Kube |
This patch adds an application icon to kube-mail, on Mac and MS Windows.
I've used conditionals because it introduces a dependency on the ECM. And because that's a new dependency I require a very recent version which introduced the possibility to create an application icon from SVG.
| Lint Skipped |
| Unit Tests Skipped |
| applications/mail/CMakeLists.txt | ||
|---|---|---|
| 45 | this change makes the app bundle executable go where it should on Mac, instead of being put into ${prefix}/bin. Changes nothing on Linux (it's the standard way of installing userland applications). | |
Ship it once the ${KDevelop_SOURCE_DIR} issue is fixed.
| applications/mail/CMakeLists.txt | ||
|---|---|---|
| 11 | ${KDevelop_SOURCE_DIR} can't be right. | |
| applications/mail/CMakeLists.txt | ||
|---|---|---|
| 11 | Damn, that's what you get from using copy/paste and looking no further when the result has the intended effect... The whole reference to the KDevelop directory can probably go, maybe even the entire line. I'll check. | |
| applications/mail/CMakeLists.txt | ||
|---|---|---|
| 11 | We both missed the fact that the ECM were already being included, all I really needed to do was require a more recent on Mac/Win32! | |