try proper order of corona()->availableScreenRect()
ClosedPublic

Authored by mart on Mar 9 2017, 5:38 PM.

Details

Summary

connect to Plasma::Corona::availableScreenRectChanged
instead of using kscreen, this way we should be more sure
that signal is emitted when it's safe to call
corona()->availableScreenRect() as the change of rect
may happen after a screen removal, so may mean
accessing a desktop view while being deleted
BUG:377298

Test Plan

notifications still pop up in the proper place,
couldn't reproduce the crash neither before nor after tough

Diff Detail

Repository
R120 Plasma Workspace
Branch
phab/notificationsavailableScreenRectChanged
Lint
No Linters Available
Unit
No Unit Test Coverage
mart created this revision.Mar 9 2017, 5:38 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 9 2017, 5:38 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Mar 10 2017, 8:15 AM
This revision is now accepted and ready to land.Mar 10 2017, 8:15 AM
This revision was automatically updated to reflect the committed changes.