Details
Details
- Reviewers
vkrause - Group Reviewers
KDE PIM - Maniphest Tasks
- T719: Refactor objecttreeparser
- Commits
- R43:beaea89c256a: add TextMessagePart
Diff Detail
Diff Detail
- Repository
- R43 KDE PIM
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| messageviewer/src/viewer/objecttreeparser.h | ||
|---|---|---|
| 446 | I assume that's also just temporary during refactoring? Otherwise we might want to look for a better name. | |
| messageviewer/src/viewer/messagepart.h | ||
|---|---|---|
| 28 | unrelated change, need to move to other patch. | |
| messageviewer/src/viewer/objecttreeparser.h | ||
| 446 | well there are only two places that refer to that function (defaultHandling and TextMessagePart). So it will be very fast to move that function out of otp.
-> TextMessagePart doesn't need to be a friend class of otp anymore. | |