Rework shortcut internals
ClosedPublic

Authored by abrahams on Nov 4 2015, 5:55 AM.

Details

Summary

Here is a diff which contains my local work done so far. Although there is always more work to do to get the internals looking cleaner, I think the core is now in an acceptable state. The primary step after this will be to implement loading and saving. Once that is finished, schemes support should be straightforward to implement.

Diff Detail

Repository
R37 Krita
Branch
KisActionRegistry-4
Lint
No Linters Available
Unit
No Unit Test Coverage
abrahams updated this revision to Diff 1150.Nov 4 2015, 5:55 AM
abrahams retitled this revision from to Here is a diff which contains my local work done so far. Although there is always more work to do to get the internals looking cleaner, I think the core is now in an acceptable state. The main additional step will be to implement loading and saving..
abrahams edited the test plan for this revision. (Show Details)
abrahams added a reviewer: rempt.
abrahams updated this object.
abrahams retitled this revision from Here is a diff which contains my local work done so far. Although there is always more work to do to get the internals looking cleaner, I think the core is now in an acceptable state. The main additional step will be to implement loading and saving. to Rework shortcut internals.Nov 4 2015, 5:57 AM
abrahams updated this object.
abrahams updated this revision to Diff 1177.Nov 4 2015, 10:01 PM

More updates. Now tool actions show up in the menu. Ownership has changed a bit. I think the notion that KisActionRegistry should own actions itself was the wrong direction.

  • Add missing .action files
  • Make XMLGUI and KoToolManager play nicely together
abrahams updated this object.Nov 5 2015, 1:41 AM
abrahams updated this revision to Diff 1275.Nov 13 2015, 8:29 AM
abrahams updated this object.
  • Polish up the shortcuts editor

Added more robust loading/saving, nicer folding options

abrahams updated this revision to Diff 1282.Nov 14 2015, 12:23 PM

Add more i18n context

This revision was automatically updated to reflect the committed changes.