Probably legacy code from before the time of QProcess (and KProcess)?
Details
Details
It still compiles and generates the same output
Diff Detail
Diff Detail
- Repository
- R452 KIOs for development
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Looks good. I don't honestly remember why I didn't use QProcess here (and I seem to have left comments for everything except that...) but there's no reason to reinvent the wheel. Don't forget to bump the version string though.
| perldoc/perldoc.cpp | ||
|---|---|---|
| 45–46 | I would bump the version here (or alternately just remove the version portion entirely and leave it something like "kio_perldoc for KF5" as this version mostly an internal detail). | |
Comment Actions
I have two other commits in the queue that may require a review (coming in few hours), one touches the way the version is passed to the perl script; I can bump the version there
Comment Actions
Reopening revision - the commit which closed this has been expunged from the history per T5577.