Differential D4962

[Folder View] Open context menu when pressing Menu key
ClosedPublic
Actions

Authored by broulik on Mar 6 2017, 4:24 PM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:895f617f0887: [Folder View] Open context menu when pressing Menu key
Summary

If items are selected, show their context menu next to the first selected item, otherwise ignore the signal and let the containment handle it which then opens the standard context menu.

Test Plan

Generic menu button handling was submitted in D4924

Pressing menu button now opens the context menu of the item at given position.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 6 2017, 4:24 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2017, 4:24 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Mar 6 2017, 4:24 PM
hein edited edge metadata.Mar 6 2017, 9:43 PM

Could you add a screenie for the pos problem you mentioned?

broulik updated this revision to Diff 12256.Mar 7 2017, 9:48 AM
broulik edited the test plan for this revision. (Show Details)
  • Use GridView currentItem
  • Cannot reproduce placement problem, I might have forgotten to actually compile after changing it to use currentItem.frame :) The context menu now properly touches the frame, even with one line of label.
hein accepted this revision.Mar 7 2017, 2:54 PM
This revision is now accepted and ready to land.Mar 7 2017, 2:54 PM
Closed by commit R119:895f617f0887: [Folder View] Open context menu when pressing Menu key (authored by broulik). · Explain WhyMar 7 2017, 3:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12256

View Options

containments/desktop/package/contents/ui/FolderView.qml

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.h

Loading...
View Options

containments/desktop/plugins/folder/foldermodel.cpp

Loading...