Pause media players on suspend

Authored by broulik on Mar 6 2017, 3:45 PM.



When suspending the machine pause any media players to avoid embarrassing situation where the machine wakes up with loud music blaring out of its speakers.

Test Plan

Suspended machine, music stopped. Default is on.

Setting in PowerDevil advanced settings. According to HIG a check box with text on the left should have label such as "Enabled"

Diff Detail

R122 Powerdevil
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 6 2017, 3:45 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2017, 3:45 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin edited edge metadata.Mar 6 2017, 4:01 PM

Looks good to me. Can you please time travel that change back to when I was a student?

andreaska added a subscriber: andreaska.EditedMar 8 2017, 1:03 PM

cause Pause media player when suspending is that long when you separate it to

left row: Media Player
right row: Pause when suspending

so it's not that long and maybe easier to understand.

Looking good to me.

hein added a subscriber: hein.Mar 20 2017, 10:18 AM

Personally I prefer the earlier version. I understand the concern about the long label, but this 'sentence structure' hurts legibility for me. For a single option a topic:option structure a la group box is pretty unusual IMHO.

This revision was automatically updated to reflect the committed changes.


Like this?

look good to me. thanks