[Folder View] Turn heading into a "hyperlink" and reduce hit area
ClosedPublic

Authored by broulik on Mar 6 2017, 1:36 PM.

Details

Summary

I often end up accidentally opening the folder in a file manager because especially when FolderView is placed on a desktop, the hit area for the label spans the entire width and a significantly taller area than the label's text height actually is.

There's also no visual cue that clicking the heading would do anything. Turn it into a "hyperlink" by underlining it on hover and using the PointingHandCursor.

Test Plan

Tested with normal labels as well as super long ones (navigating through lots of sub folders) and the MouseArea position always covers just the label's text. It also underlines just fine on hover.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 6 2017, 1:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 6 2017, 1:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Mar 6 2017, 8:53 PM

Excellent, +1

This revision is now accepted and ready to land.Mar 6 2017, 8:53 PM
This revision was automatically updated to reflect the committed changes.