Differential D4944

QuickShare: Fix text/buttons cutting off in ShowUrlDialog in HiDPI settings
ClosedPublic
Actions

Authored by yuenlim on Mar 5 2017, 5:53 PM.

Details

Reviewers
apol
Group Reviewers
Plasma
Commits
R114:6cfee0e84d0e: Fix QuickShare ShowUrlDialog getting clipped in hiDPI settings
Summary

The size of the ShowUrlDialog (the dialog that presents the paste url after a successful pastebin/imgur upload) is currently fixed on 300x300, which causes the UI elements to get clipped off, hiding the copy button and truncating the "copy automatically" text (and confused me quite a bit when I first used it :)

This patches it to use units.gridUnit like in ShareDialog.

Diff Detail

Repository
R114 Plasma Addons
Lint
Lint Skipped
Unit
Unit Tests Skipped
yuenlim created this revision.Mar 5 2017, 5:53 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 5 2017, 5:53 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
yuenlim added a comment.Mar 5 2017, 6:00 PM

before:

after:

apol accepted this revision.Mar 5 2017, 11:52 PM
This revision is now accepted and ready to land.Mar 5 2017, 11:52 PM
Closed by commit R114:6cfee0e84d0e: Fix QuickShare ShowUrlDialog getting clipped in hiDPI settings (authored by Lim Yuen Hoe <yuenhoe@hotmail.com>). · Explain WhyMar 6 2017, 2:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12191

View Options

applets/quickshare/plasmoid/contents/ui/ShowUrlDialog.qml

Loading...