- Added "font" option in View's ConfigInterface
- Added "on-the-fly-spellcheck" option in View's ConfigInterface
Details
- Reviewers
dhaumann - Group Reviewers
Frameworks KTextEditor - Commits
- R39:2df4c40ea27a: Added font and on-the-fly-spellcheck options in ConfigInterface
Tested in an application I'm currently developing. It works.
Diff Detail
- Repository
- R39 KTextEditor
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
In general, looks good, but please also extend the documentat in src/include/configinterface.h, and add an updated patch here again :-)
And thinking about it more, it also would be nice to have unit tests for the config interface, we need to add that later.
Ooops! My bad :)
Added
And thinking about it more, it also would be nice to have unit tests for the config interface, we need to add that later.
Hmmmm...... I'm working on some additional changes that I need in KTextEditor. I guess I could write the unit tests at some time in the near future
Just for info: I just added a unit test for all View and Document config values (which immediately caught some bugs). So in future, we also need to extend the unit test whenever new entries are added to the ConfigInterface.