[KTextEditor] Added font and on-the-fly-spellcheck options in ConfigInterface
ClosedPublic

Authored by jsalatas on Mar 5 2017, 9:42 AM.

Details

Summary
  • Added "font" option in View's ConfigInterface
  • Added "on-the-fly-spellcheck" option in View's ConfigInterface
Test Plan

Tested in an application I'm currently developing. It works.

Diff Detail

Repository
R39 KTextEditor
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jsalatas created this revision.Mar 5 2017, 9:42 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 5 2017, 9:42 AM
Restricted Application added a subscriber: kwrite-devel. · View Herald Transcript
dhaumann requested changes to this revision.Mar 5 2017, 10:03 AM
dhaumann added a subscriber: dhaumann.

In general, looks good, but please also extend the documentat in src/include/configinterface.h, and add an updated patch here again :-)

And thinking about it more, it also would be nice to have unit tests for the config interface, we need to add that later.

This revision now requires changes to proceed.Mar 5 2017, 10:03 AM
jsalatas updated this revision to Diff 12182.Mar 5 2017, 10:12 AM
jsalatas edited edge metadata.

Added documentation for the new options in configinterface.h

In general, looks good, but please also extend the documentat in src/include/configinterface.h, and add an updated patch here again :-)

Ooops! My bad :)
Added

And thinking about it more, it also would be nice to have unit tests for the config interface, we need to add that later.

Hmmmm...... I'm working on some additional changes that I need in KTextEditor. I guess I could write the unit tests at some time in the near future

dhaumann accepted this revision.Mar 5 2017, 10:26 AM

Looks good, please commit. Do you have commit rights, or should I commit for you?

This revision is now accepted and ready to land.Mar 5 2017, 10:26 AM

Looks good, please commit. Do you have commit rights, or should I commit for you?

Committed. Thanks!

This revision was automatically updated to reflect the committed changes.

Just for info: I just added a unit test for all View and Document config values (which immediately caught some bugs). So in future, we also need to extend the unit test whenever new entries are added to the ConfigInterface.