We currently match Krita by Name. It's classClass is "krita",
but its DesktopEntryName is org.kde.krita.desktop. However,
Krita also installs numerous additional .desktop entries to
associate more file types by itself, all of which match by
name, and the first one in the list isn't the right one. All
of those extra .desktop files are NoDisplay=true however, so
we can filter them out, which brings the match list down to
the one and only .desktop file we care for.
Details
Details
Diff Detail
Diff Detail
- Repository
- R120 Plasma Workspace
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Shouldn't we *always* exclude them, not just for name matching?
libtaskmanager/xwindowtasksmodel.cpp | ||
---|---|---|
591 | Remove |
Comment Actions
Two reasons:
- I could imagine a case where someone wants to hide a .desktop from the menu (e.g. something like a KCM) but it still has a useful Exec= and could be useful to be pinnable. Excluding an explicit DesktopEntryName match means eliminating the match, since there can be only one match due to the single namespace.
- DesktopEntryName is more explicit, and if we ever match a NoDisplay entry there we shouldn't, I actually want the 'bug' to bubble up and for us to learn about it so we can think about that case more, because it'd be really weird :).