[Folder View] Set plasmoid.busy to false when listing canceled
ClosedPublic

Authored by broulik on Mar 3 2017, 2:55 PM.

Details

Summary

When trying to access a folder that no longer exists or a KIO slave crashes or any other kind of error, instead of listingCompleted the listingCanceled signal is emitted at which point Folder View would spin indefinitely whilst showing an error at the same time.

Test Plan

Broke my desktop kio slave, got an error message but it didn't spin its spinner anymore. Spinning while loading a large directory still works.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 3 2017, 2:55 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 3 2017, 2:55 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Mar 3 2017, 4:17 PM
This revision is now accepted and ready to land.Mar 3 2017, 4:17 PM
aacid requested changes to this revision.Mar 3 2017, 8:17 PM
aacid added a subscriber: aacid.

The patch doesn't seem to apply?

This revision now requires changes to proceed.Mar 3 2017, 8:17 PM
aacid resigned from this revision.Mar 3 2017, 8:24 PM

ignore me

This revision is now accepted and ready to land.Mar 3 2017, 8:24 PM
This revision was automatically updated to reflect the committed changes.