Fix adding table relationships in Query Designer using drag&drop (regression since 3.0)
ClosedPublic

Authored by staniek on Mar 3 2017, 9:03 AM.

Details

Summary

FIXED-IN:3.0.1
BUG:376970
T5473

Note: the code in form view has been updated too but because (like in 2.9.x) autofields are disabled it's still not functional.

Test Plan

Create a new query design, insert 2 or more tables, add relation using drag and drop, add fields to the query. Move to the data view and SQL view. Expected: correct data result, SQL is present with WHERE condition.

Diff Detail

Repository
R71 Kexi
Branch
3.0
Lint
No Linters Available
Unit
No Unit Test Coverage
staniek created this revision.Mar 3 2017, 9:03 AM
Restricted Application added a project: KEXI. · View Herald TranscriptMar 3 2017, 9:03 AM
staniek edited the summary of this revision. (Show Details)Mar 3 2017, 9:05 AM
piggz accepted this revision.Mar 5 2017, 9:38 PM

Tested on 3.0 branch. Works fine.

One question. Why is the generated SQL in the form 'WHERE x.x = x.x' and not an INNER JOIN?

This revision is now accepted and ready to land.Mar 5 2017, 9:38 PM
In D4913#92854, @piggz wrote:

One question. Why is the generated SQL in the form 'WHERE x.x = x.x' and not an INNER JOIN?

It's a trace of the old SQLite driver (version 2?). Because it's internally used we will be able to switch to INNER JOIN without breaking compatibility. It would be just good to also add xxx JOIN construct to the KexiSQL parser in one go. (related wish and recent request: https://bugs.kde.org/show_bug.cgi?id=141345#c3).

This revision was automatically updated to reflect the committed changes.