[Folder View] Cancel renaming if focus is lost or popup closes
ClosedPublic

Authored by broulik on Mar 2 2017, 3:18 PM.

Details

Summary

This way when clicking outside a FolderView applet on desktop it will cancel renaming. Also, when closing a popup.

Test Plan

Started renaming a file in a folderview on my desktop, clicked outside, selection was cleared and rename was canceled.
Started renaming a file in folderview popup in panel, clicked outside, popup closed, upon reopening selection was still there but rename was canceled

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Mar 2 2017, 3:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2017, 3:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein accepted this revision.Mar 2 2017, 3:19 PM
This revision is now accepted and ready to land.Mar 2 2017, 3:19 PM
broulik added inline comments.Mar 2 2017, 3:31 PM
containments/desktop/package/contents/ui/FolderViewLayer.qml
140

Whoops, removing this was actually not intentional.

broulik updated this revision to Diff 12298.Mar 8 2017, 4:05 PM
  • Fix accidental removal of clearSelection call
This revision was automatically updated to reflect the committed changes.