Differential D4887

[Folder View] Support undo keyboard shortcut
ClosedPublic
Actions

Authored by broulik on Mar 2 2017, 1:17 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R119:3491607e70be: [Folder View] Support undo keyboard shortcut

Summary

My first reaction when having done something stupid is to hit Ctrl+Z. This didn't work with FolderView.

Test Plan

Pressed Delete to trash a file, pressed Ctrl+Z, it came back.

Diff Detail

Repository

R119 Plasma Desktop

Lint

Lint Skipped

Unit

Unit Tests Skipped

broulik created this revision.Mar 2 2017, 1:17 PM

Restricted Application added a project: Plasma. · View Herald TranscriptMar 2 2017, 1:17 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik added reviewers: Plasma, hein.Mar 2 2017, 1:17 PM

Hold on, crashes when I undo without being able to undo.

Don't crash if we cannot undo (trigger() apparently doesn't check enabled())

hein accepted this revision.Mar 2 2017, 3:14 PM

This revision is now accepted and ready to land.Mar 2 2017, 3:14 PM

Closed by commit R119:3491607e70be: [Folder View] Support undo keyboard shortcut (authored by broulik). · Explain WhyMar 2 2017, 3:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			containments/desktop/package/contents/ui/FolderView.qml (2 lines)
M			containments/desktop/plugins/folder/foldermodel.h (1 line)
M			containments/desktop/plugins/folder/foldermodel.cpp (7 lines)

Diff 12055

containments/desktop/package/contents/ui/FolderView.qml

Loading...

containments/desktop/plugins/folder/foldermodel.h

Loading...

containments/desktop/plugins/folder/foldermodel.cpp

Loading...