[lookandfeel] Add virtual keyboard to the LockScreen
ClosedPublic

Authored by graesslin on Mar 1 2017, 4:05 PM.

Details

Summary

This change integrates QtVirtualKeyboard into the Lock screen UI.

A new button is added to the bottom row to toggle the appearance of the
virtual keyboard. The actual keyboard is integrated through a Loader so
that not having qtvirtualkeyboard plugin installed results in a graceful
error instead of a failing lock screen.

When the virtual keyboard is shown the remaining UI shifts upwards. This
is done through adding the stack view into a ColumnLayout. Unfortunately
this can result in an overlap with the clock. This needs some general
improvement as on e.g. my system the clock is never really visible.

To have the virtual keyboard working in the lock screen one also needs
another change to kscreenlocker_greet.

Test Plan

See screenshots

Diff Detail

Repository
R120 Plasma Workspace
Branch
lockscreen-virtual-keyboard
Lint
No Linters Available
Unit
No Unit Test Coverage
graesslin created this revision.Mar 1 2017, 4:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 1 2017, 4:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin updated this revision to Diff 12033.Mar 1 2017, 7:28 PM

Small improvements for activating by going through Qt.inputMethods.
By that the keyboard closes when one clicks the close button.

graesslin updated this revision to Diff 12034.Mar 1 2017, 7:39 PM

Hide the user list if it does not fit on screen any more due to
keyboard being open

mart added a subscriber: mart.Mar 2 2017, 10:34 AM

this makes the virtual keyboard always enabled on every system tough?

mart added inline comments.Mar 2 2017, 10:43 AM
lookandfeel/contents/lockscreen/LockScreenUi.qml
128

I would prefer not to have this layout, or can be also tried alternatively, just a Column (which doesn't resize its children)
i would add a state machine there that distinguish between visible and hidden keyboard, when visible, the whole area slides up (will have a negative y) and with a transition animation

mart added a comment.Mar 2 2017, 11:47 AM
This comment was removed by mart.
mart accepted this revision.Mar 2 2017, 4:30 PM
This revision is now accepted and ready to land.Mar 2 2017, 4:30 PM

this makes the virtual keyboard always enabled on every system tough?

Yes, but it only shows if actively enabled through the new added button. I want to do a compromise between helpful for touch screens and not annoying for no touch screens.

This revision was automatically updated to reflect the committed changes.