Differential D4869

[Notifications Dataengine] Create KConfig object on the stack
ClosedPublic
Actions

Authored by broulik on Mar 1 2017, 4:04 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R120:891d8a3bcb23: [Notifications Dataengine] Create KConfig object on the stack
Summary

I don't see why it should be created on the heap.

Test Plan

Did a spectacle notificaton, still got the configure button and it still worked.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Mar 1 2017, 4:04 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 1 2017, 4:04 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Mar 1 2017, 4:10 PM
This revision is now accepted and ready to land.Mar 1 2017, 4:10 PM
Closed by commit R120:891d8a3bcb23: [Notifications Dataengine] Create KConfig object on the stack (authored by broulik). · Explain WhyMar 8 2017, 11:40 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12286

View Options

dataengines/notifications/notificationsengine.cpp

Loading...