Tighter Folder View item delegates.
ClosedPublic

Authored by hein on Mar 1 2017, 11:40 AM.

Details

Summary

This patch reduces margins inside the item delegate. The most
frequent piece of user feedback for Folder View is "Can you let
me change the grid size?", and the background behind the question
always turns out to be unhappiness with the large gutters between
icons and not being able to fit more icons on the desktop. A
casual comparison to other desktops (including past KDE versions)
indicates icon delegates indeed tend to be tighter. This follows
suit.

On my screen, the desktop now fits 9 instead of 7 rows of icons,
with similar gains on the horizontal axis.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hein created this revision.Mar 1 2017, 11:40 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 1 2017, 11:40 AM
hein added a comment.Mar 1 2017, 11:40 AM

Before:

After:

hein added a comment.Mar 1 2017, 11:48 AM

Additional screenshots with text lines in config set to 2:

Can we let the label get wider, though? (compare icon width vs total available delegate width – the label could occupy somewhat more width than the icon)


Especially noticeable here where the thumbnail gets wider than the label

hein added a comment.Mar 1 2017, 11:56 AM

Aye, let me try!

hein updated this revision to Diff 11999.Mar 1 2017, 11:59 AM

More horizontal space for text label.

hein added a comment.Mar 1 2017, 12:01 PM

Updated. This means there's still *slightly* less space left now than before. I considered going even more extreme (increase that width by another two smallSpacings), but it started to feel a little too cramped - but it's borderline. Could you try both locally and give feedback?

davidedmundson added inline comments.
containments/desktop/package/contents/ui/FolderItemDelegate.qml
198

you have 3*INT being added to the height
then have an icon centre aligned inside it

gridUnit/largeSpacing will always be even. smallSpacing might not be.

mart accepted this revision.Mar 1 2017, 12:45 PM
This revision is now accepted and ready to land.Mar 1 2017, 12:45 PM
This revision was automatically updated to reflect the committed changes.