Now, when the words are selected they stay scaled up to let the child know that word has been selected. When the child presses "OK", all selected words are checked and if a correct word hasn't been selected or a wrong word has been selected, "check answer" is played and the child can then select or unselect again.
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Overall I liked the concept :) For the coloring of letters, I thought may be color the letter for initial levels (when child is new to recognizing) and not display them in later levels or not highlight the letters at all (its an hint that its the correct word and makes it easy to recognise, is not much learning if the child gets the trick)? It can be an increase in difficulty. I am not sure if its a good idea but it is to be discussed if it is required and if it can be an improvement?
Comment Actions
Hi,
I'm not sure on how to do it but is it possible to only have one diff (even if there are multiple changes in the history)? There is already https://phabricator.kde.org/D4790 with comments and I'm not sure it's useful to have a new diff everytime (we'll lose the previous comments and reviewers).
I can't apply this patch to master:
error: patch failed: src/activities/letter-in-word/letter-in-word.js:224
error: src/activities/letter-in-word/letter-in-word.js: patch does not apply
https://cgit.kde.org/gcompris.git/tree/src/activities/letter-in-word/letter-in-word.js#n224
| src/activities/letter-in-word/letter-in-word.js | ||
|---|---|---|
| 253–255 | items.wordsModel.setProperty(index, "selected", !modelEntry.selected); | |
Comment Actions
Hi,
Is the patch failing because we have multiple diff or is it something else? In the former case, could we use github PR instead (to have updated diffs with every new commit) ?
edit: I haven't tried it out yet but does the Update Diff option work like we want to or does it just create a new diff all over again?
Comment Actions
I guess the Update Diff option worked as you requested. Is the patch failing because there is no bad bonus in the updated code? I can't seem to locate the problem.