Differential D4811

Fix expected value in messagefactorytest.
ClosedPublic
Actions

Authored by dfaure on Feb 26 2017, 3:21 PM.

Details

Reviewers
mlaurent
Commits
R94:ab111e47e20e: Fix expected value in messagefactorytest.
Summary

Now messagefactorytest passes. Please check if this is the correct expected value though.
I just noticed that this test is gone in master though, messagefactorytest being rewritten?

Test Plan

ctest -R messagefactorytest

Diff Detail

Repository
R94 PIM: Message Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Feb 26 2017, 3:21 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 26 2017, 3:21 PM
mlaurent accepted this revision.Mar 10 2017, 6:32 AM

Hi,
I found time to look at it (sorry I made a big work during 1 week to reduce dependencies against akonadi in several pim lib).
For me your patch is ok.

For master it's in messagefactoryngtest.cpp

Thanks
Regards

This revision is now accepted and ready to land.Mar 10 2017, 6:32 AM
Closed by commit R94:ab111e47e20e: Fix expected value in messagefactorytest. (authored by dfaure). · Explain WhyMar 10 2017, 7:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 12350

View Options

messagecomposer/autotests/messagefactoryngtest.cpp

Loading...