Differential D4800

[Task Manager] text elide doesn't work for Tooltips
AbandonedPublic
Actions

Authored by jsalatas on Feb 25 2017, 11:41 PM.

Details

Reviewers
romangg
anthonyfieroni
Group Reviewers
VDG
Plasma
Summary

Seems that height: undefined cause the elide not to work in the Tooltip headings

Test Plan

Before

After

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
jsalatas created this revision.Feb 25 2017, 11:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 25 2017, 11:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
jsalatas added a comment.Feb 25 2017, 11:45 PM

If you agree, I believe this should be committed to 5.9 branch and not wait until 5.10.

Please confirm.

romangg edited edge metadata.Feb 26 2017, 2:15 AM

Removing the undefineds increases the margins between the lines again. @anthonyfieroni had another fix for the elide a few days ago by setting the maximumLineCount property. He hadn't yet pushed it though. I would go for his solution if it retains the margins. You could try if it works for you as well. It's the last revision of D4491.

jsalatas added a comment.Feb 26 2017, 2:44 AM
In D4800#89954, @subdiff wrote:

Removing the undefineds increases the margins between the lines again. @anthonyfieroni had another fix for the elide a few days ago by setting the maximumLineCount property. He hadn't yet pushed it though. I would go for his solution if it retains the margins. You could try if it works for you as well. It's the last revision of D4491.

Yeap! I guess the result is the same to the one I want to achieve.

Thanks for mentioning it.

jsalatas abandoned this revision.Feb 26 2017, 2:44 AM

Revision Contents
Changeset List

Diff 11834

View Options

applets/taskmanager/package/contents/ui/ToolTipInstance.qml

Loading...