Add Module class + disable advanced options when module-gconf is not loaded
ClosedPublic
Actions

Authored by drosca on Feb 25 2017, 9:10 AM.

Details

Reviewers

Group Reviewers

Commits

Test Plan

Options are correctly enabled/disabled according to loaded state of module-gconf

Repository

R115 Plasma Audio Volume Applet

Branch

loaded-modules (branched from master)

Lint

No Linters Available

Unit

No Unit Test Coverage

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

broulik added inline comments.

src/modulemanager.cpp
83	singleShot?
130	Iterator / range for? (Didn't look what modules() is, though)

Fix issues

Thanks.
BTW, I update Neon's packaging (and then Kubuntu copied) to include gconf now.

This revision is now accepted and ready to land.Feb 26 2017, 1:01 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/CMakeLists.txt (1 line)
M		src/context.h (3 lines)
M		src/context.cpp (36 lines)
M		src/kcm/package/contents/ui/Advanced.qml (10 lines)
M		src/maps.h (2 lines)
P		src/module.h (48 lines) Copied from src/modulemanager.h
A	M	src/module.cpp (61 lines)
P		src/modulemanager.h (14 lines) Copied to src/module.h
M		src/modulemanager.cpp (42 lines)
M		src/pulseaudio.h (7 lines)
M		src/pulseaudio.cpp (7 lines)
M		src/qml/plugin.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11802	87df4c7		Feb 25 2017, 9:10 AM	★	★
Diff 2	11810	87df4c7	Fix issues	Feb 25 2017, 11:55 AM	★	★
Diff 3	11844	a82bcce	R115:817af4b68f6b199d91d8ff3d3900e7f2dbc95268	Feb 26 2017, 10:14 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
a12f256a213f	a03d0dc050e2	87df4c77cb69	David Rosca	Add Module class + disable advanced options when module-gconf is not loaded (Show More…)	Feb 25 2017, 9:06 AM