Details
Details
Diff Detail
Diff Detail
- Repository
- R52 KDevelop: PHP Support
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Rest LGTM
duchain/tests/duchain.cpp | ||
---|---|---|
2961 ↗ | (On Diff #11970) | implements |
2970–2972 ↗ | (On Diff #11970) | no need |
2994–2996 ↗ | (On Diff #11970) | no need |
duchain/tests/duchaintestbase.cpp | ||
72 ↗ | (On Diff #11970) | unrelated; remove |
Comment Actions
content.append("interface Iterator { function rewind(); function current(); function key(); function next(); function valid(); } "); content.append("interface ArrayAccess { function offsetExists($offset); function offsetGet($offset); function offsetSet($offset, $value); function offsetUnset($offset); }");
test fails without it It cannot find interface ArrayAccess. Similarly if i remove Iterator interface above it fails every test which implements Iterator . @zhigalin need help here thanks
duchain/tests/duchain.cpp | ||
---|---|---|
2960 ↗ | (On Diff #11970) | Just prepend arrayaccess here |
2989 ↗ | (On Diff #11970) | Just prepend arrayaccess here |
2990 ↗ | (On Diff #11970) | class A implements ArrayAccess |
duchain/tests/duchaintestbase.cpp | ||
72 ↗ | (On Diff #11970) | Not a good idea to copy paste here stuff from php standard library |