Differential D4767

Applet: Fix binding loop on ListItem height
ClosedPublic
Actions

Authored by drosca on Feb 24 2017, 5:05 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R994:a82bccea2d33: Applet: Fix binding loop on ListItem height
R115:a82bccea2d33: Applet: Fix binding loop on ListItem height
Summary

Set only one item as child of ListItem and move DropArea and MouseArea into it.

Test Plan

No more binding loop, looks same as before

Diff Detail

Repository
R115 Plasma Audio Volume Applet
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Feb 24 2017, 5:05 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 24 2017, 5:05 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
davidedmundson accepted this revision.Feb 26 2017, 1:06 AM
This revision is now accepted and ready to land.Feb 26 2017, 1:06 AM
Closed by commit R115:a82bccea2d33: Applet: Fix binding loop on ListItem height (authored by drosca). · Explain WhyFeb 26 2017, 10:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mapplet/contents/ui/ListItemBase.qml (59 lines)

Diff 11843

View Options

applet/contents/ui/ListItemBase.qml

Loading...