Differential D4760

Add path escaping to cmake completion.
ClosedPublic
Actions

Authored by ematirov on Feb 24 2017, 2:02 PM.

Details

Reviewers
kfunk
Group Reviewers
KDevelop
Commits
R32:5276b1b4ea39: Add path escaping to cmake completion.
Summary

Fixes https://bugs.kde.org/show_bug.cgi?id=338196

Diff Detail

Repository
R32 KDevelop
Branch
cmake_escape_path
Lint
No Linters Available
Unit
No Unit Test Coverage
ematirov created this revision.Feb 24 2017, 2:02 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptFeb 24 2017, 2:02 PM
ematirov edited the summary of this revision. (Show Details)Feb 24 2017, 2:04 PM
kfunk accepted this revision.Feb 24 2017, 2:32 PM
kfunk added subscribers: apol, kfunk.

LGTM. @apol?

projectmanagers/cmake/cmakecodecompletionmodel.cpp
65

static ...

This revision is now accepted and ready to land.Feb 24 2017, 2:32 PM
ematirov updated this revision to Diff 11765.Feb 24 2017, 2:40 PM
kfunk added a comment.Feb 24 2017, 3:24 PM

Go for it, 5.1 branch please

Closed by commit R32:5276b1b4ea39: Add path escaping to cmake completion. (authored by ematirov). · Explain WhyFeb 24 2017, 5:19 PM
This revision was automatically updated to reflect the committed changes.
ematirov marked an inline comment as done.

Revision Contents
Changeset List

Diff 11762

View Options

projectmanagers/cmake/cmakecodecompletionmodel.cpp

Loading...