Differential D4754

[kcheckpass] Drop the ACCEPT_ENV compatibility define
ClosedPublic
Actions

Authored by graesslin on Feb 24 2017, 6:14 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R133:3f999c5b86cd: [kcheckpass] Drop the ACCEPT_ENV compatibility define
Summary

Given the code comment this was just for compatibility to accept some
values from the environment. The env variables KCHECKPASS_USER and
KDE_PAM_ACTION are according to lxr.kde.org nowhere in KDE's source
repository defined.

I think it's time for this code to rest in peace.

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Feb 24 2017, 6:14 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 24 2017, 6:14 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 24 2017, 10:26 AM
mart added a subscriber: mart.

also, influencing kcheckpass by environment variable may be a potential security issue

This revision is now accepted and ready to land.Feb 24 2017, 10:26 AM
Closed by commit R133:3f999c5b86cd: [kcheckpass] Drop the ACCEPT_ENV compatibility define (authored by graesslin). · Explain WhyFeb 24 2017, 1:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11758

View Options

greeter/autotests/fakekcheckpass.c

Loading...
View Options

kcheckpass/kcheckpass.c

Loading...