Differential D4744

ReceiveFileJob: Don't cancel the request right after accepting it
ClosedPublic
Actions

Authored by drosca on Feb 23 2017, 2:22 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R97:def41978a633: ReceiveFileJob: Don't cancel the request right after accepting it
Summary

KNotification::closed is emitted also when one of the notification
actions was triggered.

BUG: 376773
FIXED-IN: 5.8.7

Diff Detail

Repository
R97 Bluedevil
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.Feb 23 2017, 2:22 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 23 2017, 2:22 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
marten added a subscriber: marten.Feb 23 2017, 3:03 PM
marten added inline comments.
src/kded/receivefilejob.h
69

Allowed in C++11, but would this not be clearer done in the constructor initialization list?

drosca updated this revision to Diff 11721.Feb 23 2017, 7:15 PM

Initialize in constructor

mart accepted this revision.Feb 24 2017, 10:42 AM
This revision is now accepted and ready to land.Feb 24 2017, 10:42 AM
Closed by commit R97:def41978a633: ReceiveFileJob: Don't cancel the request right after accepting it (authored by drosca). · Explain WhyFeb 24 2017, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11750

View Options

src/kded/receivefilejob.h

Loading...
View Options

src/kded/receivefilejob.cpp

Loading...