Fonts KCM: Fix layout of hinting settings, port away from KDE4
ClosedPublic

Authored by marten on Feb 23 2017, 12:18 PM.

Details

Summary

This change improves the layout of the font hinting sub-dialogue of this KCM. Previously there was no spacing around or between the GUI elements and the combo boxes did not line up:

Now the dialogue uses a QFormLayout (but left aligned as discussed in D2853) with style default spacing:

In addition some porting away from KDE4 support is done:

KDialog -> QDialog
KApplication -> QApplication
KProcess -> QProcess
KStandardDirs -> KSharedConfig
KDoubleNumInput -> QDoubleSpinBox

There is, however, some KDE4 porting still remaining to be done, since I'm not sure whether there are Frameworks equivalents to these at the moment:

KGlobalSettings::emitChange(KGlobalSettings::FontChanged);
KFontDialog::getFontDiff()

Test Plan

Built plasma-desktop with these changes, checked correct appearance and operation of Fonts KCM.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
marten created this revision.Feb 23 2017, 12:18 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 23 2017, 12:18 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 23 2017, 2:29 PM
This revision is now accepted and ready to land.Feb 23 2017, 2:29 PM
This revision was automatically updated to reflect the committed changes.