when adding extra actions to the drop menu,
even if the menu was already shown, the cancel action should be the
last anyways for usability reasons
Details
Details
- Reviewers
dfaure - Group Reviewers
Frameworks Plasma - Commits
- R241:cae36e0efc65: make sure the cancel action is last
drop menu from folderview gets populated correctly
Diff Detail
Diff Detail
- Repository
- R241 KIO
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I like the encapsulation into a different class.
| src/widgets/dropjob.cpp | ||
|---|---|---|
| 63 | nullptr | |
| 171 | unnecessary copying (refcounting), the two QLists should be passed as const ref. | |
| 177 | (which would avoid the detaching here) | |
| 353–354 | please clean up | |
| src/widgets/dropjob.h | ||
| 38 ↗ | (On Diff #11674) | I don't think this is needed, nothing else in the header refers to it (I guess it was an initial solution with private slots that you then moved to the private class) |
| src/widgets/dropjob.h | ||
|---|---|---|
| 38 ↗ | (On Diff #11682) | still here? |
| src/widgets/dropjob.h | ||
|---|---|---|
| 38 ↗ | (On Diff #11682) | used for class KIO::DropMenu : public QMenu in dropjob.cpp, |
| src/widgets/dropjob.h | ||
|---|---|---|
| 38 ↗ | (On Diff #11682) | Not a good enough reason to have it in the public header (which doesn't use it anywhere), you can move that fwd decl to the .cpp file. |
| src/widgets/dropjob.h | ||
|---|---|---|
| 38 ↗ | (On Diff #11682) | done |