Details
Details
- Reviewers
vkrause - Group Reviewers
KDE PIM - Maniphest Tasks
- T719: Refactor objecttreeparser
Diff Detail
Diff Detail
- Repository
- R43 KDE PIM
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
two branches are left without tests and I don't know how to reach them.
messageviewer/src/viewer/objecttreeparser.cpp | ||
---|---|---|
1225 | I tried very long to reach this if, but failed, because also an empty content is parsed as one child from kmime side. Any idea of a email structure to reach this one? | |
1256 | This brancxh I also don't reach. I tried the following but this results in the complete bbbb part as data without any subchilds. Only if I process the data part explitly as KMime::Message(data->decodedContent()) this has childs: MIME-Version: 1.0 Content-Type: multipart/encrypted; boundary="aaaa" Content-Transfer-Encoding: 7Bit --aaaa Content-Transfer-Encoding: 7Bit Content-Type: application/pgp-encrypted Version 1 --aaaa Content-Type: application/octet-stream MIME-Version: 1.0 Content-Type: random/content; boundary="bbbb" Content-Transfer-Encoding: 7Bit --bbbb Content-Type: application/foo asdfghjkl --bbbb Content-Type: application/octet-stream qwertzuiop --bbbb-- --aaaa-- |
Comment Actions
Looks ok to me. It's quite possible that these branches were actually just routine defensive checks against nullptr, or go back to mimelib behavior before we ported to KMime, ie. asserts there are probably ok.