Differential D4719

T4121 Get a better native palette format.
ClosedPublic
Actions

Authored by woltherav on Feb 22 2017, 3:50 PM.

Details

Reviewers

rempt

Group Reviewers

Krita

Maniphest Tasks

T4121: Get a better native palette format.

Commits

R37:b9d9a40fe85e: [FEATURE]: new palette format! (Merge of palette-branch)

Summary

This branch...

Makes a new filetype for Krita palettes: KPL.

These palettes can have groups, and unlike GPL palettes, they can save high bit depth colors. Then, we have the necessary functions to deal with adding/removing/searching for colorsetentries inside groups.

Thanks to @lsegovia we also have SBZ(swatchbooker) support.

I was not able to add embedded palette support. I came across a bug that I couldn't resolve, as noted in T5282.

This fixes T4121

Test Plan

It's build, I've been testing it for a few months now, etc.

Diff Detail

Repository

R37 Krita

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

woltherav created this revision.Feb 22 2017, 3:50 PM

woltherav created this object with edit policy "Krita (Project)".

woltherav edited the summary of this revision. (Show Details)

woltherav added a subscriber: lsegovia.

D3254 should probably be closed once this is merged.

Please merge the branch non-squashed, so we have the separate commits for the separate things. Next, i guess, we'll have to start working on the palette editor :-)

This revision is now accepted and ready to land.Mar 14 2017, 1:48 PM

Closed by commit R37:b9d9a40fe85e: [FEATURE]: new palette format! (Merge of palette-branch) (authored by woltherav). · Explain WhyMar 15 2017, 11:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			libs/image/kis_properties_configuration.cc (2 lines)
M			libs/image/recorder/kis_recorded_paint_action.cpp (2 lines)
M			libs/koplugin/KisMimeDatabase.cpp (2 lines)
M			libs/pigment/CMakeLists.txt (1 line)
M			libs/pigment/KoColor.h (5 lines)
M			libs/pigment/KoColor.cpp (6 lines)
M			libs/pigment/resources/KoColorSet.h (98 lines)
M			libs/pigment/resources/KoColorSet.cpp (916 lines)
M			libs/pigment/tests/TestKoColor.cpp (2 lines)
M			libs/store/KoStore.h (21 lines)
M			libs/store/KoStore.cpp (71 lines)
M			libs/ui/KisColorsetChooser.cpp (4 lines)
M			libs/ui/KisPaletteModel.cpp (8 lines)
M			libs/ui/kis_config.cc (4 lines)
M			libs/widgets/KoColorSetWidget.cpp (71 lines)
M			libs/widgets/KoColorSetWidget_p.h (2 lines)
M			libs/widgets/KoEditColorSetDialog.cpp (18 lines)
M			libs/widgets/KoResourceServerProvider.cpp (2 lines)
M			plugins/dockers/palettedocker/palettedocker_dock.cpp (12 lines)
M			plugins/filters/gradientmap/krita_filter_gradient_map.cpp (2 lines)
M			plugins/impex/libkra/kis_kra_loader.cpp (2 lines)
M			plugins/paintops/libpaintop/kis_dynamic_sensor.cc (3 lines)
M			plugins/tools/tool_lazybrush/kis_tool_lazy_brush_options_widget.cpp (16 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	11628			Feb 22 2017, 3:47 PM	★	★
Diff 2	12485	7e7c378	R37:b9d9a40fe85e40c5efa1d9649be8d29e4b191d00	Mar 15 2017, 11:19 AM	★	★

T4121 Get a better native palette format.ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 12485

libs/image/kis_properties_configuration.cc

libs/image/recorder/kis_recorded_paint_action.cpp

libs/koplugin/KisMimeDatabase.cpp

libs/pigment/CMakeLists.txt

libs/pigment/KoColor.h

libs/pigment/KoColor.cpp

libs/pigment/resources/KoColorSet.h

libs/pigment/resources/KoColorSet.cpp

libs/pigment/tests/TestKoColor.cpp

libs/store/KoStore.h

libs/store/KoStore.cpp

libs/ui/KisColorsetChooser.cpp

libs/ui/KisPaletteModel.cpp

libs/ui/kis_config.cc

libs/widgets/KoColorSetWidget.cpp

libs/widgets/KoColorSetWidget_p.h

libs/widgets/KoEditColorSetDialog.cpp

libs/widgets/KoResourceServerProvider.cpp

plugins/dockers/palettedocker/palettedocker_dock.cpp

plugins/filters/gradientmap/krita_filter_gradient_map.cpp

plugins/impex/libkra/kis_kra_loader.cpp

plugins/paintops/libpaintop/kis_dynamic_sensor.cc

plugins/tools/tool_lazybrush/kis_tool_lazy_brush_options_widget.cpp

T4121 Get a better native palette format.
ClosedPublic
Actions

Revision Contents
Changeset List