Add some more directives to MIPS assembler highlighting
Needs ReviewPublic

Authored by arichardson on Feb 22 2017, 11:28 AM.



Add a few 64-bit MIPS instruction mnemonics

Add c-preprocessor.xml highlighting file to be included

Extracted and slightly modified from isocpp.xml

Make GNU Assembler and MIPS assembler use c-preprocessor.xml

This fixes highlighting of e.g. #include

Diff Detail

R216 Syntax Highlighting
No Linters Available
No Unit Test Coverage
arichardson created this revision.Feb 22 2017, 11:28 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 22 2017, 11:28 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dhaumann edited edge metadata.Feb 23 2017, 8:04 PM

I think in general a good idea.

Some comments:

  • Could you update the patch with the mentioned issues?
  • Could you also provide two test cases (under MIT license) that demonstrate MIPS and GNU Assembler highlighting? That would be very helpful for our unit tests.

I would prefer

extensions="" mimetype="" hidden="true" priority="1"


Are you also ok with MIT license?

dhaumann requested changes to this revision.Jun 17 2017, 2:47 PM


This revision now requires changes to proceed.Jun 17 2017, 2:47 PM
arichardson marked 2 inline comments as done.

address comments
will try to add tests soon

Could you provide a test snippet now? I will integrate this then.

Restricted Application added a project: Kate. · View Herald TranscriptAug 12 2018, 5:20 PM
Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. · View Herald Transcript

@arichardson friendly ping :-) In case you don't have the time, it's also OK to paste some example code in a comment here (MIT licensed, please). Then, we can proceed.

Sorry, was busy with other stuff so completely forgot about this. I'll update this soon.