| apol | |
| kfunk |
| KDevelop |
Fix a crash when gdb produces malformed output. The crash was reported in https://bugs.kde.org/show_bug.cgi?id=376595.
It is actually a bug in gdb which can't handle invalid/out-of-scope watchpoints gracefully.
Instead of assert and crash the whole IDE, debugger errors are now reported to the user in a dialog.
And debug session will automatically end in this case.
A minimal test case from the reporter: https://bugs.kde.org/show_bug.cgi?id=376595#c20
| No Linters Available |
| No Unit Test Coverage |
LGTM, I just hope this doesn't lead to lots of undesired debugger exits? In other words, those 'wild replies' as you name them are very rare?
I name it after "wild pointer" because both of them are dangling around :P
In most of the cases the whole IDE simply crashes, so the debug session can't continue anyway. There's one change of behavior though. Before this patch, KDevelop will ignore the reply without a pending command if the reply is a done/running. Now this will be reported and cause an exit of the debug session.
None of these should ever happen in theory, but if they do, some thing must be wrong in kdevelop or the debugger. So I think it's better to inform the user and encourage a bug report.