Add export macro for private classes with unittest.
ClosedPublic

Authored by dfaure on Feb 21 2017, 4:24 PM.

Details

Summary

Otherwise I get

undefined reference to `vtable for MailCommon::KMFilterAccountList'

when linking filteractionmissingaccountdialogtest.
Must be a consequence of the recent changes in cmake git (autogen feature).

There are a ton more files that are included directly rather than the
classes being exported though (which can make refactorings harder, e.g.
when new cpp files are added as dependencies of the existing ones,
suddenly it becomes complex to know what to compile in).

Should we go fully in the direction of exporting the stuff we need
when building tests, and compiling these cpp files only once, as a result?

Test Plan

Now it builds with clang

Diff Detail

Repository
R92 PIM: Common Mail Support
Branch
Applications/16.12
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Feb 21 2017, 4:24 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 21 2017, 4:24 PM
dvratil added inline comments.Feb 22 2017, 10:56 PM
src/CMakeLists.txt
8

I think we are using -DBUILD_TESTING in PIM

dfaure updated this revision to Diff 11658.Feb 23 2017, 8:22 AM

rename define

dvratil accepted this revision.Feb 24 2017, 2:16 PM
This revision is now accepted and ready to land.Feb 24 2017, 2:16 PM
dfaure closed this revision.Feb 24 2017, 2:43 PM