in Qt5.6 the QAction creators need a parent object passed as a parameter. unfortunately they don't have a default for the parent as nullptr so we need to explicitly pass that.
Details
Details
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
btw, not related to this patch but I just noticed..
on line 534 of containmentinterface.cpp, do you want to delete 'choices' or 'choice'?
Comment Actions
Thanks, this must be the cause for the CI failures at https://build.kde.org/view/Frameworks%20kf5-qt5/job/plasma-framework%20master%20stable-kf5-qt5/
Comment Actions
on line 534 of containmentinterface.cpp, do you want to delete 'choices' or 'choice'?
choices, the current code, looks correct and matches the comment on 505/530