fix compile with Qt5.6
ClosedPublic

Authored by winterz on Feb 20 2017, 2:26 PM.

Details

Summary

in Qt5.6 the QAction creators need a parent object passed as a parameter. unfortunately they don't have a default for the parent as nullptr so we need to explicitly pass that.

Test Plan

compile with Qt5.6.2

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
winterz created this revision.Feb 20 2017, 2:26 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 20 2017, 2:26 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript

btw, not related to this patch but I just noticed..
on line 534 of containmentinterface.cpp, do you want to delete 'choices' or 'choice'?

davidedmundson accepted this revision.Feb 20 2017, 4:15 PM
This revision is now accepted and ready to land.Feb 20 2017, 4:15 PM

on line 534 of containmentinterface.cpp, do you want to delete 'choices' or 'choice'?

choices, the current code, looks correct and matches the comment on 505/530

winterz closed this revision.Feb 20 2017, 4:39 PM

c4b01b015554f52577507506d18c9bcb4e7ac5b6committed in