Map StartupWMClass for Chrome apps instead of RegExp'ing the name

Authored by broulik on Feb 20 2017, 12:41 PM.



We only matched for the "Default" suffix which is the default profile but this breaks when having apps installed in different profiles where they get e.g. "Profile_1" suffix.

BUG: 376695
FIXED-IN: 5.10.0

Test Plan

Could go into 5.9.3?

My normal Chrome apps still work and I created a new second profile and its app now properly groups as separate app. Normale Chrome browser windows continue to work normally.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 20 2017, 12:41 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 20 2017, 12:41 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
hein edited edge metadata.Feb 20 2017, 12:43 PM

How certain are you that .desktop files for Chrome usually specify a StartupWMClass?

According to Chromium source code in in CreateAppListDesktopShortcut (called by CreateShortcuts) it calls GetDesktopFileContentsForCommand which always ends up doing g_key_file_set_string(key_file, kDesktopEntry, "StartupWMClass", wmclass.c_str());

hein accepted this revision.Feb 20 2017, 1:00 PM

And I guess the rule is only for apps and not Chrome's .desktop itself which distros may fuck up.

OK then ... fine for 5.9 by me.

This revision is now accepted and ready to land.Feb 20 2017, 1:00 PM
This revision was automatically updated to reflect the committed changes.