Differential D4647

AuthJob: emit finished() when dialog is rejected
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 17 2017, 12:20 PM.

Details

Reviewers
dvratil
Commits
R477:6e00198ede6a: AuthJob: emit finished() when dialog is rejected
Summary

Otherwise there is no way to detect whether the authentication has been
manually canceled by the user.

Test Plan

tested in kio-gdrive.

Diff Detail

Repository
R477 KGAPI Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 11446.Feb 17 2017, 12:20 PM
elvisangelaccio retitled this revision from to AuthJob: emit finished() when dialog is rejected.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: dvratil.
dvratil added inline comments.Feb 17 2017, 1:24 PM
src/core/authjob.cpp
254

Why the lambda? Passing a pointer to the AuthJob::emitFinished() method should work here.

elvisangelaccio updated this revision to Diff 11451.Feb 17 2017, 3:09 PM

Removed useless lambda

dvratil accepted this revision.Feb 17 2017, 3:14 PM
dvratil edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2017, 3:14 PM
elvisangelaccio marked an inline comment as done.Feb 17 2017, 3:15 PM
Closed by commit R477:6e00198ede6a: AuthJob: emit finished() when dialog is rejected (authored by elvisangelaccio). · Explain WhyFeb 17 2017, 3:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/authjob.cpp (1 line)

Diff 11453

View Options

src/core/authjob.cpp

Loading...