Differential D4640

Fix array allocation for non-continuous cpu numbers
ClosedPublic
Actions

Authored by cfeck on Feb 17 2017, 2:09 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R106:e4c58c2f6ef7: Fix array allocation for non-continuous cpu numbers
Summary

As per https://bugs.kde.org/show_bug.cgi?id=376537 ksysguard crashes, when /proc/stat returns the following file:

cpu0 x y z
cpu3 x y z

The issue is that it counts two CPUs, and later allocates two entries for the array, but uses the CPU number to index that array. An array with indices 0 and 3 should have 4 entries, not 2.

Test Plan

Compiled. Could not test, because this is an SMP machine.

Diff Detail

Repository
R106 KSysguard
Lint
Lint Skipped
Unit
Unit Tests Skipped
cfeck updated this revision to Diff 11423.Feb 17 2017, 2:09 AM
cfeck retitled this revision from to Fix array allocation for non-continuous cpu numbers.
cfeck updated this object.
cfeck edited the test plan for this revision. (Show Details)
cfeck added a reviewer: Plasma.
cfeck set the repository for this revision to R106 KSysguard.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 17 2017, 2:09 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart accepted this revision.Feb 17 2017, 3:03 PM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Feb 17 2017, 3:03 PM
Closed by commit R106:e4c58c2f6ef7: Fix array allocation for non-continuous cpu numbers (authored by cfeck). · Explain WhyFeb 19 2017, 4:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mksysguardd/Linux/stat.c (3 lines)

Diff 11423

View Options

ksysguardd/Linux/stat.c

Loading...