Differential D4629

Install camelcase headers
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 16 2017, 11:24 AM.

Details

Reviewers
mck182
Commits
R155:b11bf00e7d22: Install camelcase headers
Summary

Install camelcase headers auto-generated by ecm.

Test Plan

Builds, headers are generated and installed as expected.

Diff Detail

Repository
R155 KAccounts Integration
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio updated this revision to Diff 11399.Feb 16 2017, 11:24 AM
elvisangelaccio retitled this revision from to Install camelcase headers.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: mck182.
elvisangelaccio edited the summary of this revision. (Show Details)Feb 23 2017, 2:51 PM
mck182 accepted this revision.Feb 25 2017, 4:12 AM

Are you sure this doesn't break any existing stuff that is using these headers?

This revision is now accepted and ready to land.Feb 25 2017, 4:12 AM
elvisangelaccio added a comment.Feb 25 2017, 11:05 AM
In D4629#89631, @mck182 wrote:

Are you sure this doesn't break any existing stuff that is using these headers?

The old headers are still installed, but anyway if something breaks hopefully build.kde.org will tell us.

Closed by commit R155:b11bf00e7d22: Install camelcase headers (authored by elvisangelaccio). · Explain WhyFeb 25 2017, 11:17 AM
This revision was automatically updated to reflect the committed changes.
elvisangelaccio added a comment.Feb 25 2017, 11:49 AM
In D4629#89657, @elvisangelaccio wrote:
In D4629#89631, @mck182 wrote:

Are you sure this doesn't break any existing stuff that is using these headers?

The old headers are still installed, but anyway if something breaks hopefully build.kde.org will tell us.

Ok, actually kaccounts_export.h was wrongly removed, fixed in bb1f1c6dd6.

Revision Contents
Changeset List

PathPackages
Msrc/lib/CMakeLists.txt (17 lines)

Diff 11807

View Options

src/lib/CMakeLists.txt

Loading...