Track the actual pressed keys in ModifierOnlyShortcuts

Authored by graesslin on Feb 15 2017, 6:09 AM.



With this change the ModifierOnlyShortcut starts to track the actual
pressed keys instead using a counter of combined pressed keys.

This should help for the cases that we get unsynced key codes.
E.g. if we get two key presses for the same key and only one release
we don't get out of sync. Similar if we get a key release for a key
which wasn't pressed, we don't go out of sync.

Test Plan

Auto test still passes

Diff Detail

R108 KWin
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
graesslin updated this revision to Diff 11359.Feb 15 2017, 6:09 AM
graesslin retitled this revision from to Track the actual pressed keys in ModifierOnlyShortcuts.
graesslin updated this object.
graesslin edited the test plan for this revision. (Show Details)
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin. · View Herald TranscriptFeb 15 2017, 6:09 AM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript

@subdiff Can you please try whether this change fixes the problem with your external keyboard?

davidedmundson accepted this revision.Feb 23 2017, 2:15 PM
This revision is now accepted and ready to land.Feb 23 2017, 2:15 PM
This revision was automatically updated to reflect the committed changes.