FEATURE: 384194
This allows to view metadata (such as image dimensions, audio file album and artist information, etc) from the properties dialog. Through this, tagging and rating functionality is also somewhat more accessible.
Details
Details
- Reviewers
aacid dfaure - Group Reviewers
VDG Plasma - Commits
- R824:832aa1b7d96f: [Baloo Widgets] Add KPropertiesDialog Plugin with file metadata
I don't like tooltips and neither do I like the Dolphin sidebar. Also, I observed the properties dialog being the go-to place for Windows users to find this information (Windows has it here).
- Doesn't have the configure widget where you can configure what to show (in Dolphin will just follow its settings) - didn't want to copy the confige dialog from there
Diff Detail
Diff Detail
- Repository
- R824 Baloo Widgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
looks sensible.
| Messages.sh | ||
|---|---|---|
| 6 ↗ | (On Diff #11350) | is this not overwriting the generated extraction above? |
| src/filepropertiesplugin/baloofilepropertiesplugin.cpp | ||
| 51 | I would argue that the FileMetaDataWidget should have the spacer on the end of it's own grid layout. A widget should be able to handle being resized gracefully without making every containing app do it. (but I don't super object to this either. If this were on RB, imagine I haven't checked the "Open an Issue" checkbox) | |
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
| 9 | where does this list come from? | |
| Messages.sh | ||
|---|---|---|
| 6 ↗ | (On Diff #11350) | This is obviously wrong, it would duplicate a lot of stuff that the previous line grabbed. I think you misunderstood the use of "grep -v" in there, which is meant to *exclude* naturalqueryparser. Which means including everything else, including your filepropertiesplugin. So AFAICS you don't need any change to this file at all, just revert. |
| src/filepropertiesplugin/CMakeLists.txt | ||
| 13 | If you're bored, the properties dialog could be ported to load plugins with json descriptions instead of desktop files. | |
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 9 | I went through all extractors in KFileMetaData and looked at what they support. Unfortunately KPropertiesDialog does not support wildcards. But then, showing this tab only for files where we can get meaningful information (read: stuff that isn't already on the main tab like file size and modified date), is probably better anyway. | |
| Messages.sh | ||
|---|---|---|
| 6 ↗ | (On Diff #11350) | As others pointed out: this is not needed: the new strings are already going to be extracted into baloowidgets.pot. Try it for yourself: |
Comment Actions
The layout looks good and is according to the HIG.
You probably shouldn't display duplicate information, but if I understood the comments correct this is already addressed.
A case could be made that this information is actually the most interesting one, and could have a more prominent place, then on the last tab. Would it be possible to display the information together with the information of the current first tab?
Comment Actions
Would it be possible to display the information together with the information of the current first tab?
No.
Also, currently I cannot tell the thing to exclude certain information (like file type and other info already shown on the first page).
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 9 | Well, as soon as your wrote all/all in the list, everything else was moot, since that means "any file or dir". (Note that whoever says all/all should say application/octet-stream instead, all/all is deprecated. Possibly adding inode/directory if directories should be supported too.) Something else: your list of ServiceTypes contains many mimetypes; this works, but for clarity you should move them all to the MimeType key, and leave only KPropertiesDialog/Plugin as servicetype (which it is). | |
Comment Actions
@broulik Any update here? Looks like this is about 99% done, and it would be a shame not to to get it in. I often find myself wishing this information in the Properties window.
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 10 | MimeType=inode/directory;application/octet-stream ? | |
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 10 | The widget is primarily for showing additional file metadata (such as image sizes), there's no such extra information for folders, so I chose not to show it in this case. | |
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 4 | The baloo icon has a magnifying glass in it which is associated with searching. | |
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 4 | I don't think this icon is visible in the UI anywhere, certainly not in the properties dialog | |
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 10 | I tag and comment some folders containing e.g. tv-series. | |
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 4 | That's was also my first thought. Not sure, but it might appear in dolphin settings > services | |
| src/filepropertiesplugin/baloofilepropertiesplugin.desktop | ||
|---|---|---|
| 4 | Btw you can submit multiple comments at once, this way I don't get a gazillion emails each asking a single question :) Just hit "Submit" once you've added all your comments | |
Comment Actions
Sorry, we were overlapping. I should have hit the update page link in the lower left.
BTW: Mind to explain this "Restricted Application added a project:" .... to me? Please.