Differential D4611

Check the background is valid when choosing background type
ClosedPublic
Actions

Authored by davidedmundson on Feb 14 2017, 4:47 PM.

Details

Reviewers
broulik
Group Reviewers
Plasma
Commits
R123:ec3040634bbd: Merge branch 'Plasma/5.9'
R123:1c77df276e45: Check the background is valid when choosing background type
Summary

I rushed in an emergency fix for 5.9.1 that added support for setting
the background type, which was a new property someone added to the
breeze theme in 5.9.1.

My last patch doesn't support clearing the background properly.
Effectively the old code would always set the type to "image".

BUG: 376484

Test Plan

Set background to image. Checked config
Cleared background. Checked config

Diff Detail

Repository
R123 SDDM Configuration Panel (KCM)
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson updated this revision to Diff 11343.Feb 14 2017, 4:47 PM
davidedmundson retitled this revision from to Check the background is valid when choosing background type.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 14 2017, 4:47 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Feb 14 2017, 4:49 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Feb 14 2017, 4:49 PM
Closed by commit R123:1c77df276e45: Check the background is valid when choosing background type (authored by davidedmundson). · Explain WhyFeb 14 2017, 5:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/themeconfig.cpp (10 lines)

Diff 11344

View Options

src/themeconfig.cpp

Loading...