Improved integration of (quick) search bar in panel
ClosedPublic

Authored by abika on Feb 14 2017, 4:07 PM.

Details

Summary

Always draw focus rectangle in panel view even when not focused. Now, the
text box in the search panel can normally be focused when typing in it.


GUI: made KrStyleProxy a subclass of QProxyStyle and removed all unnecessary overrides

Panel: show dashed border around current item even if panel is not focused
I couldn't find a better way than adding a custom draw command to each view implementation.

Panel: don't switch focus to panel view when typing in search bar

FIXED: [ 375639 ] Allow typing special characters (e.g. with accent or acute) in search bar
BUG: 375639

Test Plan
  • checked style behaviour+tested changing the Qt style
  • checked correct key behaviour on
    • keypress in panel when search bar is hidden
    • keypress in panel when search bar is shown
    • keypress in search panel

Diff Detail

Repository
R167 Krusader
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
abika updated this revision to Diff 11341.Feb 14 2017, 4:07 PM
abika retitled this revision from to Improved integration of (quick) search bar in panel.
abika updated this object.
abika edited the test plan for this revision. (Show Details)
abika added a reviewer: Krusader.
martinkostolny accepted this revision.Feb 14 2017, 8:06 PM
martinkostolny added a reviewer: martinkostolny.
martinkostolny added a subscriber: martinkostolny.

Working very nicely, thanks! :-)

This revision is now accepted and ready to land.Feb 14 2017, 8:06 PM
asensi accepted this revision.Feb 15 2017, 8:57 AM
asensi added a reviewer: asensi.
asensi added a subscriber: asensi.

Great! It gets compiled using Kubuntu 16.10 and also the bug 375639 seems to be solved, thank you very much, Alex!

This revision was automatically updated to reflect the committed changes.