finish support for opening compressed packages
ClosedPublic

Authored by mart on Feb 14 2017, 3:29 PM.

Details

Summary

it's possible to do setPath(zipfile path) and open
a compressed package as it was a real one, done for
uninstalling packages passing zips as parameters
or installing plasmoids by drag and drop
on the desktop, but this didn't really work
as it wasn't incomplete as tempRoot should be
used in place of d->path for the package to work and be valid.

Test Plan

autotests still work, now installing plasmoids by drag and drop
works

Diff Detail

Repository
R290 KPackage
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart updated this revision to Diff 11336.Feb 14 2017, 3:29 PM
mart retitled this revision from to finish support for opening compressed packages.
mart updated this object.
mart edited the test plan for this revision. (Show Details)
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 14 2017, 3:29 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
hein requested changes to this revision.Feb 16 2017, 11:10 AM
hein added a reviewer: hein.
This revision now requires changes to proceed.Feb 16 2017, 11:10 AM
hein added inline comments.Feb 16 2017, 11:13 AM
src/kpackage/package.cpp
362–369

Could you rewrite this for readability a bit? Nested ternary operators just to use a diff var name is ugly, we have implicitly shared strings :)

mart updated this revision to Diff 11400.Feb 16 2017, 11:26 AM
mart edited edge metadata.
  • readability++
hein accepted this revision.Feb 16 2017, 11:31 AM
hein edited edge metadata.
This revision is now accepted and ready to land.Feb 16 2017, 11:31 AM
This revision was automatically updated to reflect the committed changes.