Help stamp tool find the image so it can work right
AbandonedPublic

Authored by scottpetrovic on Feb 13 2017, 9:16 PM.

Details

Reviewers
None
Group Reviewers
Krita
Summary

On my windows machine, there seemed to be a missing reference to the image data when a stamp was being created. The image was being set near the beginning of the application, but the reference turns into null by the time the stamp tip needs to use it.

This fix just sets the image data when the brush editor appears. It appears to make the stamp brush tip work

I checked my Ubuntu system later and the current stamp problem also happens on that. for some reason I thought it was only on Windows, but I was mistaken.

uhh. I can't find the "Krita" repository when assigning it in the ticket, so I just assigned it to the dithering extension.

Test Plan
  1. started krita
  2. make a dot on the screen
  3. make a selection around it
  4. open the brush editor, go to predefined brush tips,
  5. click create a stamp

result: shows the stamp preview image

previously it was not showing a preview area. This is tested on Windows 8.1

Diff Detail

Repository
R505 Krita Extension - Dithering
Lint
Lint Skipped
Unit
Unit Tests Skipped
scottpetrovic retitled this revision from to Help stamp tool find the image so it can work right.
scottpetrovic updated this object.
scottpetrovic edited the test plan for this revision. (Show Details)
scottpetrovic added a reviewer: Krita.
scottpetrovic set the repository for this revision to R505 Krita Extension - Dithering.
scottpetrovic added a project: Krita.
scottpetrovic added a subscriber: rempt.
Restricted Application added a subscriber: woltherav. ยท View Herald TranscriptFeb 13 2017, 9:16 PM
scottpetrovic abandoned this revision.Feb 14 2017, 2:19 PM

commited.