Differential D4595

Port from QDateTime::currentDateTime() to QElapsedTimer
ClosedPublic
Actions

Authored by dfaure on Feb 13 2017, 12:24 PM.

Details

Reviewers
apol
Commits
R241:344c500a686e: Port from QDateTime::currentDateTime() to QElapsedTimer
Summary
  • fixes a race condition (due to tzset inside QDateTime)
  • should be faster
Test Plan

compiled qt5+kf5 with clang,libc++,tsan; then ran kio's threadtest

Diff Detail

Repository
R241 KIO
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure updated this revision to Diff 11283.Feb 13 2017, 12:24 PM
dfaure retitled this revision from to Port from QDateTime::currentDateTime() to QElapsedTimer.
dfaure updated this object.
dfaure edited the test plan for this revision. (Show Details)
dfaure added a subscriber: Frameworks.
Restricted Application added a project: Frameworks. · View Herald TranscriptFeb 13 2017, 12:24 PM
apol accepted this revision.Feb 13 2017, 2:08 PM
apol added a reviewer: apol.
This revision is now accepted and ready to land.Feb 13 2017, 2:08 PM
dfaure closed this revision.Feb 13 2017, 2:09 PM
dfaure added inline comments.Feb 13 2017, 10:22 PM
src/core/slave.cpp
190

Oops, elapsed() returns milliseconds, so this was missing a divide by 1000. Added now in https://commits.kde.org/kio/24ff23c6943b1156f29c80de5586db73bee7d2f5

Revision Contents
Changeset List

PathPackages
Msrc/core/slave.cpp (7 lines)

Diff 11283

View Options

src/core/slave.cpp

Loading...