Differential D4594

Don't break compatibility with old configs
ClosedPublic
Actions

Authored by elvisangelaccio on Feb 13 2017, 10:26 AM.

Details

Reviewers
apol
broulik
Commits
R99:0a7fafc7e2f4: Don't break compatibility with old configs
Summary

Commit 4a06c4d34f doesn't take into account old config files where the
value of the key is 'true', breaking the getter for the warps property.

Test Plan

Add gtk-primary-button-warps-slider=true both in ~/.gtkrc-2.0 and
~/.config/gtk-3.0/settings.ini; open gtk-config kcm, warps checkbox is now checked
as expected.

Diff Detail

Repository
R99 KDE Gtk Configuration Tool
Branch
Plasma/5.8
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 11274.Feb 13 2017, 10:26 AM
elvisangelaccio retitled this revision from to Don't break compatibility with old configs.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: apol.
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 13 2017, 10:26 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik accepted this revision.Feb 13 2017, 12:10 PM
broulik added a reviewer: broulik.
This revision is now accepted and ready to land.Feb 13 2017, 12:10 PM
Closed by commit R99:0a7fafc7e2f4: Don't break compatibility with old configs (authored by elvisangelaccio). · Explain WhyFeb 14 2017, 9:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/abstractappearance.cpp (7 lines)

Diff 11274

View Options

src/abstractappearance.cpp

Loading...