Differential D4579

Do not treat filename in selection as URL
ClosedPublic
Actions

Authored by fvogt on Feb 11 2017, 9:08 PM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R135:e70f8134a2bc: Do not treat filename in selection as URL
R135:f5f2c5e5f428: merge Plasma/5.9
R135:6e314a7d0590: Merge branch 'Plasma/5.9'
Summary

KFileWidget::setSelection(QString &) accepts either absolute URLs
or relative paths. If the filename contains a :, it gets treated
as a URL and gets rejected. This forces setSelection to parse
it as URL.

CCBUG: 376365

Diff Detail

Repository
R135 Integration for Qt applications in Plasma
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt updated this revision to Diff 11240.Feb 11 2017, 9:08 PM
fvogt retitled this revision from to Do not treat filename in selection as URL.
fvogt updated this object.
fvogt edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 11 2017, 9:08 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
fvogt added a reviewer: Plasma.Feb 11 2017, 9:09 PM

https://bugs.kde.org/show_bug.cgi?id=376365 contains reproducer, with this change it works.

mart accepted this revision.Feb 13 2017, 11:31 AM
mart added a reviewer: mart.
This revision is now accepted and ready to land.Feb 13 2017, 11:31 AM
Closed by commit R135:e70f8134a2bc: Do not treat filename in selection as URL (authored by fvogt). · Explain WhyFeb 13 2017, 3:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 11294

View Options

src/platformtheme/kdeplatformfiledialoghelper.cpp

Loading...