Solve some problem when received and sending messages
AbandonedPublic

Authored by patrickelectric on Feb 11 2017, 7:21 PM.

Details

Diff Detail

Repository
R232 AtCore
Branch
solveReceiveProblems
Lint
No Linters Available
Unit
No Unit Test Coverage
patrickelectric retitled this revision from to Solve some problem when received and sending messages.
patrickelectric edited the test plan for this revision. (Show Details)
  • Sending messages do not depends if commands are avaiable to read
rizzitello added inline comments.Feb 13 2017, 1:30 PM
src/atcore.cpp
267

Logic here is that if the machine can take a command we process the Queue. The reason is if you machine does nto send idle waits this should get commands pushed. Also if we do get idle waits we can process the command rather then add to the stack of todo commands. we need to fix this in serialLayer if possible. if not we may have to redo how we use printerStates so we can reasonably predict if the printer is ready for a command by using IDLE state and BUSY when processing.

src/plugins/marlinplugin.cpp
66

This one is needed because the return for temperature is
ok T ....

we have to check this is the case on other firmwares rather then do a blanket change.

patrickelectric marked an inline comment as done.Feb 13 2017, 2:32 PM
patrickelectric added inline comments.
src/plugins/marlinplugin.cpp
66

The 'ok' check don't happen, because of the else.
if check Temp
else
if check ok

And Marlin don't send ok when sending temperature.

patrickelectric abandoned this revision.EditedFeb 28 2017, 12:56 PM
patrickelectric marked an inline comment as done.

Working on Ref D4777